From 3a8199ec2867c8c38751a323641ce972c8fee572 Mon Sep 17 00:00:00 2001 From: Oleg Klimov Date: Fri, 10 Mar 2017 19:46:46 +0300 Subject: [PATCH] Fix formatting --- .../ImportURDFDemo/BulletUrdfImporter.cpp | 34 +++++++++++++++---- .../Importers/ImportURDFDemo/UrdfParser.cpp | 9 +++-- 2 files changed, 34 insertions(+), 9 deletions(-) diff --git a/examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp b/examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp index 844b0adef..553c34b12 100644 --- a/examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp +++ b/examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp @@ -467,13 +467,26 @@ bool findExistingMeshFile( b3Warning("%s: invalid mesh filename '%s'\n", error_message_prefix.c_str(), fn.c_str()); return false; } + std::string ext; std::string ext_ = fn.substr(fn.size()-4); for (std::string::iterator i=ext_.begin(); i!=ext_.end(); ++i) + { ext += char(tolower(*i)); - if (ext==".dae") *out_type = UrdfGeometry::FILE_COLLADA; - else if (ext==".stl") *out_type = UrdfGeometry::FILE_STL; - else if (ext==".obj") *out_type = UrdfGeometry::FILE_OBJ; + } + + if (ext==".dae") + { + *out_type = UrdfGeometry::FILE_COLLADA; + } + else if (ext==".stl") + { + *out_type = UrdfGeometry::FILE_STL; + } + else if (ext==".obj") + { + *out_type = UrdfGeometry::FILE_OBJ; + } else { b3Warning("%s: invalid mesh filename extension '%s'\n", error_message_prefix.c_str(), ext.c_str()); @@ -489,9 +502,12 @@ bool findExistingMeshFile( shorter.push_back(".."); shorter.push_back("."); int cnt = urdf_path.size(); - for (int i=0; im_geometry.m_meshFileType) { + switch (collision->m_geometry.m_meshFileType) + { case FILE_OBJ: if (collision->m_flags & URDF_FORCE_CONCAVE_TRIMESH) { diff --git a/examples/Importers/ImportURDFDemo/UrdfParser.cpp b/examples/Importers/ImportURDFDemo/UrdfParser.cpp index 4ccb9b14a..cd0a19acc 100644 --- a/examples/Importers/ImportURDFDemo/UrdfParser.cpp +++ b/examples/Importers/ImportURDFDemo/UrdfParser.cpp @@ -439,7 +439,8 @@ bool UrdfParser::parseGeometry(UrdfGeometry& geom, TiXmlElement* g, ErrorLogger* } else { - if (!shape->Attribute("filename")) { + if (!shape->Attribute("filename")) + { logger->reportError("Mesh must contain a filename attribute"); return false; } @@ -447,7 +448,11 @@ bool UrdfParser::parseGeometry(UrdfGeometry& geom, TiXmlElement* g, ErrorLogger* bool success = findExistingMeshFile( m_urdf2Model.m_sourceFile, shape->Attribute("filename"), sourceFileLocation(shape), &geom.m_meshFileName, &geom.m_meshFileType); - if (!success) return false; // warning printed + if (!success) + { + // warning printed + return false; + } geom.m_meshScale.setValue(1,1,1); if (shape->Attribute("scale"))