From bb72a91080d55819af15e1278fec8b70e94d8471 Mon Sep 17 00:00:00 2001 From: Tigran Gasparian Date: Mon, 4 Jun 2018 15:10:48 +0200 Subject: [PATCH 1/3] Clears the user data cache when syncUserData is called. Adds unit test for the UserData functons. Changes the char pointer in btHashString to std::string. There were problems where the object owning the string memory would deallocate the string, making the btHashString object invalid. --- .../PhysicsClientSharedMemory.cpp | 9 + examples/SharedMemory/PhysicsDirect.cpp | 10 + examples/pybullet/unittests/userDataTest.py | 237 ++++++++++++++++++ src/LinearMath/btHashMap.h | 5 +- 4 files changed, 259 insertions(+), 2 deletions(-) create mode 100644 examples/pybullet/unittests/userDataTest.py diff --git a/examples/SharedMemory/PhysicsClientSharedMemory.cpp b/examples/SharedMemory/PhysicsClientSharedMemory.cpp index 0f2ec78c0..eeb619200 100644 --- a/examples/SharedMemory/PhysicsClientSharedMemory.cpp +++ b/examples/SharedMemory/PhysicsClientSharedMemory.cpp @@ -1385,6 +1385,15 @@ const SharedMemoryStatus* PhysicsClientSharedMemory::processServerStatus() { if (serverCmd.m_type == CMD_SYNC_USER_DATA_COMPLETED) { B3_PROFILE("CMD_SYNC_USER_DATA_COMPLETED"); + // Remove all cached user data entries. + for(int i=0; im_bodyJointMap.size(); i++) + { + BodyJointInfoCache** bodyJointsPtr = m_data->m_bodyJointMap.getAtIndex(i); + if (bodyJointsPtr && *bodyJointsPtr) + { + (*bodyJointsPtr)->m_jointToUserDataMap.clear(); + } + } const int numIdentifiers = serverCmd.m_syncUserDataArgs.m_numUserDataIdentifiers; if (numIdentifiers > 0) { m_data->m_tempBackupServerStatus = m_data->m_lastServerStatus; diff --git a/examples/SharedMemory/PhysicsDirect.cpp b/examples/SharedMemory/PhysicsDirect.cpp index 6bf1004a0..77c53dec7 100644 --- a/examples/SharedMemory/PhysicsDirect.cpp +++ b/examples/SharedMemory/PhysicsDirect.cpp @@ -695,6 +695,7 @@ void PhysicsDirect::processAddUserData(const struct SharedMemoryStatus& serverCm (userDataCachePtr)->m_userDataMap.insert(userDataGlobalId.m_userDataId, SharedMemoryUserData(serverCmd.m_userDataResponseArgs.m_key)); userDataPtr = (userDataCachePtr)->m_userDataMap[userDataGlobalId.m_userDataId]; userDataPtr->replaceValue(dataStream,serverCmd.m_userDataResponseArgs.m_valueLength,userDataValue.m_type); + (userDataCachePtr)->m_keyToUserDataIdMap.insert(serverCmd.m_userDataResponseArgs.m_key, userDataGlobalId.m_userDataId); } } } @@ -1127,6 +1128,15 @@ void PhysicsDirect::postProcessStatus(const struct SharedMemoryStatus& serverCmd case CMD_SYNC_USER_DATA_COMPLETED: { B3_PROFILE("CMD_SYNC_USER_DATA_COMPLETED"); + // Remove all cached user data entries. + for(int i=0; im_bodyJointMap.size(); i++) + { + BodyJointInfoCache2** bodyJointsPtr = m_data->m_bodyJointMap.getAtIndex(i); + if (bodyJointsPtr && *bodyJointsPtr) + { + (*bodyJointsPtr)->m_jointToUserDataMap.clear(); + } + } const int numIdentifiers = serverCmd.m_syncUserDataArgs.m_numUserDataIdentifiers; b3UserDataGlobalIdentifier *identifiers = new b3UserDataGlobalIdentifier[numIdentifiers]; memcpy(identifiers, &m_data->m_bulletStreamDataServerToClient[0], numIdentifiers * sizeof(b3UserDataGlobalIdentifier)); diff --git a/examples/pybullet/unittests/userDataTest.py b/examples/pybullet/unittests/userDataTest.py new file mode 100644 index 000000000..c35c905ff --- /dev/null +++ b/examples/pybullet/unittests/userDataTest.py @@ -0,0 +1,237 @@ +import unittest +import pybullet + +PLANE_PATH = "plane.urdf" +ROBOT_PATH = "r2d2.urdf" + +class TestUserDataMethods(unittest.TestCase): + + def setUp(self): + self.client_id = pybullet.connect(pybullet.SHARED_MEMORY) + + def tearDown(self): + pybullet.resetSimulation() + pybullet.disconnect() + + def testAddUserData(self): + plane_id = pybullet.loadURDF(PLANE_PATH) + uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + + # Retrieve user data and make sure it's correct. + self.assertEqual(b"MyValue1", pybullet.getUserData(plane_id, 0, uid1)) + self.assertEqual(b"MyValue2", pybullet.getUserData(plane_id, 0, uid2)) + self.assertEqual(b"MyValue3", pybullet.getUserData(plane_id, 0, uid3)) + self.assertEqual(b"MyValue4", pybullet.getUserData(plane_id, 0, uid4)) + + # Disconnect/reconnect and make sure that the user data is synced back. + pybullet.disconnect() + pybullet.connect(pybullet.SHARED_MEMORY) + + self.assertEqual(b"MyValue1", pybullet.getUserData(plane_id, 0, uid1)) + self.assertEqual(b"MyValue2", pybullet.getUserData(plane_id, 0, uid2)) + self.assertEqual(b"MyValue3", pybullet.getUserData(plane_id, 0, uid3)) + self.assertEqual(b"MyValue4", pybullet.getUserData(plane_id, 0, uid4)) + + pybullet.resetSimulation() + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid1)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid3)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid4)) + + + def testGetNumUserData(self): + pybullet.connect(pybullet.SHARED_MEMORY) + plane_id = pybullet.loadURDF(PLANE_PATH) + uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + + self.assertEqual(4, pybullet.getNumUserData(plane_id, 0)) + + pybullet.disconnect() + pybullet.connect(pybullet.SHARED_MEMORY) + + self.assertEqual(4, pybullet.getNumUserData(plane_id, 0)) + + + def testReplaceUserData(self): + pybullet.connect(pybullet.SHARED_MEMORY) + plane_id = pybullet.loadURDF(PLANE_PATH) + uid = pybullet.addUserData(plane_id, 0, "MyKey", "MyValue") + + self.assertEqual(b"MyValue", pybullet.getUserData(plane_id, 0, uid)) + + new_uid = pybullet.addUserData(plane_id, 0, "MyKey", "MyNewValue") + self.assertEqual(uid, new_uid) + self.assertEqual(b"MyNewValue", pybullet.getUserData(plane_id, 0, uid)) + + pybullet.disconnect() + pybullet.connect(pybullet.SHARED_MEMORY) + + self.assertEqual(b"MyNewValue", pybullet.getUserData(plane_id, 0, uid)) + + def testGetUserDataId(self): + pybullet.connect(pybullet.SHARED_MEMORY) + plane_id = pybullet.loadURDF(PLANE_PATH) + uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + + self.assertEqual(uid1, pybullet.getUserDataId(plane_id, 0, "MyKey1")) + self.assertEqual(uid2, pybullet.getUserDataId(plane_id, 0, "MyKey2")) + self.assertEqual(uid3, pybullet.getUserDataId(plane_id, 0, "MyKey3")) + self.assertEqual(uid4, pybullet.getUserDataId(plane_id, 0, "MyKey4")) + + pybullet.disconnect() + pybullet.connect(pybullet.SHARED_MEMORY) + + self.assertEqual(uid1, pybullet.getUserDataId(plane_id, 0, "MyKey1")) + self.assertEqual(uid2, pybullet.getUserDataId(plane_id, 0, "MyKey2")) + self.assertEqual(uid3, pybullet.getUserDataId(plane_id, 0, "MyKey3")) + self.assertEqual(uid4, pybullet.getUserDataId(plane_id, 0, "MyKey4")) + + + def testRemoveUserData(self): + pybullet.connect(pybullet.SHARED_MEMORY) + plane_id = pybullet.loadURDF(PLANE_PATH) + uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + + pybullet.removeUserData(plane_id, 0, uid2) + + self.assertEqual(3, pybullet.getNumUserData(plane_id, 0)) + self.assertEqual(-1, pybullet.getUserDataId(plane_id, 0, "MyKey2")) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) + self.assertEqual(b"MyValue1", pybullet.getUserData(plane_id, 0, uid1)) + self.assertEqual(b"MyValue3", pybullet.getUserData(plane_id, 0, uid3)) + self.assertEqual(b"MyValue4", pybullet.getUserData(plane_id, 0, uid4)) + + pybullet.disconnect() + pybullet.connect(pybullet.SHARED_MEMORY) + + self.assertEqual(3, pybullet.getNumUserData(plane_id, 0)) + self.assertEqual(-1, pybullet.getUserDataId(plane_id, 0, "MyKey2")) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) + self.assertEqual(b"MyValue1", pybullet.getUserData(plane_id, 0, uid1)) + self.assertEqual(b"MyValue3", pybullet.getUserData(plane_id, 0, uid3)) + self.assertEqual(b"MyValue4", pybullet.getUserData(plane_id, 0, uid4)) + + + def testIterateAllUserData(self): + pybullet.connect(pybullet.SHARED_MEMORY) + plane_id = pybullet.loadURDF(PLANE_PATH) + uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + + entries = set() + for i in range(pybullet.getNumUserData(plane_id, 0)): + userDataId, key = pybullet.getUserDataInfo(plane_id, 0, i) + value = pybullet.getUserData(plane_id, 0, userDataId); + entries.add((userDataId, key, value)) + + self.assertTrue((uid1, b"MyKey1", b"MyValue1") in entries) + self.assertTrue((uid2, b"MyKey2", b"MyValue2") in entries) + self.assertTrue((uid3, b"MyKey3", b"MyValue3") in entries) + self.assertTrue((uid4, b"MyKey4", b"MyValue4") in entries) + self.assertEqual(4, len(entries)) + + + def testRemoveBody(self): + pybullet.connect(pybullet.SHARED_MEMORY) + plane_id = pybullet.loadURDF(PLANE_PATH) + uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + + pybullet.removeBody(plane_id) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid1)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid3)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid4)) + + pybullet.disconnect() + pybullet.connect(pybullet.SHARED_MEMORY) + + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid1)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid3)) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid4)) + + def testMultipleBodies(self): + pybullet.connect(pybullet.SHARED_MEMORY) + plane1 = pybullet.loadURDF(PLANE_PATH) + plane2 = pybullet.loadURDF(PLANE_PATH) + + uid1 = pybullet.addUserData(plane1, 0, "MyKey1", "This is plane 1 - 1") + uid2 = pybullet.addUserData(plane1, 0, "MyKey2", "This is plane 1 - 2") + + uid3 = pybullet.addUserData(plane2, 0, "MyKey1", "This is plane 2 - 1") + uid4 = pybullet.addUserData(plane2, 0, "MyKey2", "This is plane 2 - 2") + uid5 = pybullet.addUserData(plane2, 0, "MyKey3", "This is plane 2 - 3") + + self.assertEqual(b"This is plane 1 - 1", pybullet.getUserData(plane1, 0, pybullet.getUserDataId(plane1, 0, "MyKey1"))) + self.assertEqual(b"This is plane 1 - 2", pybullet.getUserData(plane1, 0, pybullet.getUserDataId(plane1, 0, "MyKey2"))) + + self.assertEqual(b"This is plane 2 - 1", pybullet.getUserData(plane2, 0, pybullet.getUserDataId(plane2, 0, "MyKey1"))) + self.assertEqual(b"This is plane 2 - 2", pybullet.getUserData(plane2, 0, pybullet.getUserDataId(plane2, 0, "MyKey2"))) + self.assertEqual(b"This is plane 2 - 3", pybullet.getUserData(plane2, 0, pybullet.getUserDataId(plane2, 0, "MyKey3"))) + + + def testMultipleLinks(self): + pybullet.connect(pybullet.SHARED_MEMORY) + + body_id = pybullet.loadURDF(ROBOT_PATH) + num_links = pybullet.getNumJoints(body_id) + + self.assertTrue(num_links > 1) + + for link_index in range(num_links): + uid1 = pybullet.addUserData(body_id, link_index, "MyKey1", "Value1 for link %s" % link_index) + uid2 = pybullet.addUserData(body_id, link_index, "MyKey2", "Value2 for link %s" % link_index) + + for link_index in range(num_links): + uid1 = pybullet.getUserDataId(body_id, link_index, "MyKey1") + uid2 = pybullet.getUserDataId(body_id, link_index, "MyKey2") + self.assertEqual(("Value1 for link %s" % link_index).encode(), pybullet.getUserData(body_id, link_index, uid1)) + self.assertEqual(("Value2 for link %s" % link_index).encode(), pybullet.getUserData(body_id, link_index, uid2)) + + def testMultipleClients(self): + client1 = self.client_id + client2 = pybullet.connect(pybullet.SHARED_MEMORY) + + plane_id = pybullet.loadURDF(PLANE_PATH, physicsClientId=client1) + pybullet.syncBodyInfo(physicsClientId=client2) + + # Add user data on client 1, check on client 1 + uid = pybullet.addUserData(plane_id, 0, "MyKey", "MyValue", physicsClientId=client1) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid, physicsClientId=client2)) + pybullet.syncUserData(physicsClientId=client2) + self.assertEqual(b"MyValue", pybullet.getUserData(plane_id, 0, uid, physicsClientId=client2)) + + # Overwrite the value on client 2, check on client 1 + pybullet.addUserData(plane_id, 0, "MyKey", "MyNewValue", physicsClientId=client2) + self.assertEqual(b"MyValue", pybullet.getUserData(plane_id, 0, uid, physicsClientId=client1)) + pybullet.syncUserData(physicsClientId=client1) + self.assertEqual(b"MyNewValue", pybullet.getUserData(plane_id, 0, uid, physicsClientId=client1)) + + # Remove user data on client 1, check on client 2 + pybullet.removeUserData(plane_id, 0, uid, physicsClientId=client1) + self.assertEqual(b"MyNewValue", pybullet.getUserData(plane_id, 0, uid, physicsClientId=client2)) + pybullet.syncUserData(physicsClientId=client2) + self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid, physicsClientId=client2)) + + pybullet.disconnect(physicsClientId=client2) + + +if __name__ == "__main__": + unittest.main() diff --git a/src/LinearMath/btHashMap.h b/src/LinearMath/btHashMap.h index f43e76a80..7965c11f6 100644 --- a/src/LinearMath/btHashMap.h +++ b/src/LinearMath/btHashMap.h @@ -17,12 +17,13 @@ subject to the following restrictions: #ifndef BT_HASH_MAP_H #define BT_HASH_MAP_H +#include #include "btAlignedObjectArray.h" ///very basic hashable string implementation, compatible with btHashMap struct btHashString { - const char* m_string; + std::string m_string; unsigned int m_hash; SIMD_FORCE_INLINE unsigned int getHash()const @@ -71,7 +72,7 @@ struct btHashString bool equals(const btHashString& other) const { return (m_string == other.m_string) || - (0==portableStringCompare(m_string,other.m_string)); + (0==portableStringCompare(m_string.c_str(),other.m_string.c_str())); } From c49e060e81b796a8bca911c1091ec31ce5898aed Mon Sep 17 00:00:00 2001 From: Tigran Gasparian Date: Mon, 4 Jun 2018 19:40:16 +0200 Subject: [PATCH 2/3] Starts bullet server when testsuite is ran, uses pybullet_utils to manage clients. --- examples/pybullet/unittests/userDataTest.py | 292 ++++++++++---------- 1 file changed, 147 insertions(+), 145 deletions(-) diff --git a/examples/pybullet/unittests/userDataTest.py b/examples/pybullet/unittests/userDataTest.py index c35c905ff..661298997 100644 --- a/examples/pybullet/unittests/userDataTest.py +++ b/examples/pybullet/unittests/userDataTest.py @@ -1,141 +1,147 @@ import unittest import pybullet +from pybullet_utils import bullet_client + PLANE_PATH = "plane.urdf" ROBOT_PATH = "r2d2.urdf" + class TestUserDataMethods(unittest.TestCase): + @classmethod + def setUpClass(cls): + TestUserDataMethods.server = bullet_client.BulletClient(connection_mode=pybullet.GUI_SERVER) + + @classmethod + def tearDownClass(cls): + del TestUserDataMethods.server + def setUp(self): - self.client_id = pybullet.connect(pybullet.SHARED_MEMORY) + self.client = bullet_client.BulletClient(pybullet.SHARED_MEMORY) def tearDown(self): - pybullet.resetSimulation() - pybullet.disconnect() + self.client.resetSimulation() + del self.client def testAddUserData(self): - plane_id = pybullet.loadURDF(PLANE_PATH) - uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") - uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") - uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") - uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + plane_id = self.client.loadURDF(PLANE_PATH) + uid1 = self.client.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = self.client.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = self.client.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = self.client.addUserData(plane_id, 0, "MyKey4", "MyValue4") # Retrieve user data and make sure it's correct. - self.assertEqual(b"MyValue1", pybullet.getUserData(plane_id, 0, uid1)) - self.assertEqual(b"MyValue2", pybullet.getUserData(plane_id, 0, uid2)) - self.assertEqual(b"MyValue3", pybullet.getUserData(plane_id, 0, uid3)) - self.assertEqual(b"MyValue4", pybullet.getUserData(plane_id, 0, uid4)) + self.assertEqual(b"MyValue1", self.client.getUserData(plane_id, 0, uid1)) + self.assertEqual(b"MyValue2", self.client.getUserData(plane_id, 0, uid2)) + self.assertEqual(b"MyValue3", self.client.getUserData(plane_id, 0, uid3)) + self.assertEqual(b"MyValue4", self.client.getUserData(plane_id, 0, uid4)) # Disconnect/reconnect and make sure that the user data is synced back. - pybullet.disconnect() - pybullet.connect(pybullet.SHARED_MEMORY) + del self.client + self.client = bullet_client.BulletClient(pybullet.SHARED_MEMORY) - self.assertEqual(b"MyValue1", pybullet.getUserData(plane_id, 0, uid1)) - self.assertEqual(b"MyValue2", pybullet.getUserData(plane_id, 0, uid2)) - self.assertEqual(b"MyValue3", pybullet.getUserData(plane_id, 0, uid3)) - self.assertEqual(b"MyValue4", pybullet.getUserData(plane_id, 0, uid4)) + self.assertEqual(b"MyValue1", self.client.getUserData(plane_id, 0, uid1)) + self.assertEqual(b"MyValue2", self.client.getUserData(plane_id, 0, uid2)) + self.assertEqual(b"MyValue3", self.client.getUserData(plane_id, 0, uid3)) + self.assertEqual(b"MyValue4", self.client.getUserData(plane_id, 0, uid4)) - pybullet.resetSimulation() - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid1)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid3)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid4)) + self.client.resetSimulation() + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid1)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid2)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid3)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid4)) def testGetNumUserData(self): - pybullet.connect(pybullet.SHARED_MEMORY) - plane_id = pybullet.loadURDF(PLANE_PATH) - uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") - uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") - uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") - uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + plane_id = self.client.loadURDF(PLANE_PATH) + uid1 = self.client.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = self.client.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = self.client.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = self.client.addUserData(plane_id, 0, "MyKey4", "MyValue4") - self.assertEqual(4, pybullet.getNumUserData(plane_id, 0)) + self.assertEqual(4, self.client.getNumUserData(plane_id, 0)) - pybullet.disconnect() - pybullet.connect(pybullet.SHARED_MEMORY) + del self.client + self.client = bullet_client.BulletClient(pybullet.SHARED_MEMORY) - self.assertEqual(4, pybullet.getNumUserData(plane_id, 0)) + self.assertEqual(4, self.client.getNumUserData(plane_id, 0)) def testReplaceUserData(self): - pybullet.connect(pybullet.SHARED_MEMORY) - plane_id = pybullet.loadURDF(PLANE_PATH) - uid = pybullet.addUserData(plane_id, 0, "MyKey", "MyValue") + plane_id = self.client.loadURDF(PLANE_PATH) + uid = self.client.addUserData(plane_id, 0, "MyKey", "MyValue") - self.assertEqual(b"MyValue", pybullet.getUserData(plane_id, 0, uid)) + self.assertEqual(b"MyValue", self.client.getUserData(plane_id, 0, uid)) - new_uid = pybullet.addUserData(plane_id, 0, "MyKey", "MyNewValue") + new_uid = self.client.addUserData(plane_id, 0, "MyKey", "MyNewValue") self.assertEqual(uid, new_uid) - self.assertEqual(b"MyNewValue", pybullet.getUserData(plane_id, 0, uid)) + self.assertEqual(b"MyNewValue", self.client.getUserData(plane_id, 0, uid)) - pybullet.disconnect() - pybullet.connect(pybullet.SHARED_MEMORY) + del self.client + self.client = bullet_client.BulletClient(pybullet.SHARED_MEMORY) - self.assertEqual(b"MyNewValue", pybullet.getUserData(plane_id, 0, uid)) + self.assertEqual(b"MyNewValue", self.client.getUserData(plane_id, 0, uid)) def testGetUserDataId(self): - pybullet.connect(pybullet.SHARED_MEMORY) - plane_id = pybullet.loadURDF(PLANE_PATH) - uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") - uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") - uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") - uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + plane_id = self.client.loadURDF(PLANE_PATH) + uid1 = self.client.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = self.client.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = self.client.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = self.client.addUserData(plane_id, 0, "MyKey4", "MyValue4") - self.assertEqual(uid1, pybullet.getUserDataId(plane_id, 0, "MyKey1")) - self.assertEqual(uid2, pybullet.getUserDataId(plane_id, 0, "MyKey2")) - self.assertEqual(uid3, pybullet.getUserDataId(plane_id, 0, "MyKey3")) - self.assertEqual(uid4, pybullet.getUserDataId(plane_id, 0, "MyKey4")) + self.assertEqual(uid1, self.client.getUserDataId(plane_id, 0, "MyKey1")) + self.assertEqual(uid2, self.client.getUserDataId(plane_id, 0, "MyKey2")) + self.assertEqual(uid3, self.client.getUserDataId(plane_id, 0, "MyKey3")) + self.assertEqual(uid4, self.client.getUserDataId(plane_id, 0, "MyKey4")) - pybullet.disconnect() - pybullet.connect(pybullet.SHARED_MEMORY) + del self.client + self.client = bullet_client.BulletClient(pybullet.SHARED_MEMORY) - self.assertEqual(uid1, pybullet.getUserDataId(plane_id, 0, "MyKey1")) - self.assertEqual(uid2, pybullet.getUserDataId(plane_id, 0, "MyKey2")) - self.assertEqual(uid3, pybullet.getUserDataId(plane_id, 0, "MyKey3")) - self.assertEqual(uid4, pybullet.getUserDataId(plane_id, 0, "MyKey4")) + self.assertEqual(uid1, self.client.getUserDataId(plane_id, 0, "MyKey1")) + self.assertEqual(uid2, self.client.getUserDataId(plane_id, 0, "MyKey2")) + self.assertEqual(uid3, self.client.getUserDataId(plane_id, 0, "MyKey3")) + self.assertEqual(uid4, self.client.getUserDataId(plane_id, 0, "MyKey4")) def testRemoveUserData(self): - pybullet.connect(pybullet.SHARED_MEMORY) - plane_id = pybullet.loadURDF(PLANE_PATH) - uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") - uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") - uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") - uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + plane_id = self.client.loadURDF(PLANE_PATH) + uid1 = self.client.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = self.client.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = self.client.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = self.client.addUserData(plane_id, 0, "MyKey4", "MyValue4") - pybullet.removeUserData(plane_id, 0, uid2) + self.client.removeUserData(plane_id, 0, uid2) - self.assertEqual(3, pybullet.getNumUserData(plane_id, 0)) - self.assertEqual(-1, pybullet.getUserDataId(plane_id, 0, "MyKey2")) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) - self.assertEqual(b"MyValue1", pybullet.getUserData(plane_id, 0, uid1)) - self.assertEqual(b"MyValue3", pybullet.getUserData(plane_id, 0, uid3)) - self.assertEqual(b"MyValue4", pybullet.getUserData(plane_id, 0, uid4)) + self.assertEqual(3, self.client.getNumUserData(plane_id, 0)) + self.assertEqual(-1, self.client.getUserDataId(plane_id, 0, "MyKey2")) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid2)) + self.assertEqual(b"MyValue1", self.client.getUserData(plane_id, 0, uid1)) + self.assertEqual(b"MyValue3", self.client.getUserData(plane_id, 0, uid3)) + self.assertEqual(b"MyValue4", self.client.getUserData(plane_id, 0, uid4)) - pybullet.disconnect() - pybullet.connect(pybullet.SHARED_MEMORY) + del self.client + self.client = bullet_client.BulletClient(pybullet.SHARED_MEMORY) - self.assertEqual(3, pybullet.getNumUserData(plane_id, 0)) - self.assertEqual(-1, pybullet.getUserDataId(plane_id, 0, "MyKey2")) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) - self.assertEqual(b"MyValue1", pybullet.getUserData(plane_id, 0, uid1)) - self.assertEqual(b"MyValue3", pybullet.getUserData(plane_id, 0, uid3)) - self.assertEqual(b"MyValue4", pybullet.getUserData(plane_id, 0, uid4)) + self.assertEqual(3, self.client.getNumUserData(plane_id, 0)) + self.assertEqual(-1, self.client.getUserDataId(plane_id, 0, "MyKey2")) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid2)) + self.assertEqual(b"MyValue1", self.client.getUserData(plane_id, 0, uid1)) + self.assertEqual(b"MyValue3", self.client.getUserData(plane_id, 0, uid3)) + self.assertEqual(b"MyValue4", self.client.getUserData(plane_id, 0, uid4)) def testIterateAllUserData(self): - pybullet.connect(pybullet.SHARED_MEMORY) - plane_id = pybullet.loadURDF(PLANE_PATH) - uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") - uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") - uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") - uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + plane_id = self.client.loadURDF(PLANE_PATH) + uid1 = self.client.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = self.client.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = self.client.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = self.client.addUserData(plane_id, 0, "MyKey4", "MyValue4") entries = set() - for i in range(pybullet.getNumUserData(plane_id, 0)): - userDataId, key = pybullet.getUserDataInfo(plane_id, 0, i) - value = pybullet.getUserData(plane_id, 0, userDataId); + for i in range(self.client.getNumUserData(plane_id, 0)): + userDataId, key = self.client.getUserDataInfo(plane_id, 0, i) + value = self.client.getUserData(plane_id, 0, userDataId); entries.add((userDataId, key, value)) self.assertTrue((uid1, b"MyKey1", b"MyValue1") in entries) @@ -146,91 +152,87 @@ class TestUserDataMethods(unittest.TestCase): def testRemoveBody(self): - pybullet.connect(pybullet.SHARED_MEMORY) - plane_id = pybullet.loadURDF(PLANE_PATH) - uid1 = pybullet.addUserData(plane_id, 0, "MyKey1", "MyValue1") - uid2 = pybullet.addUserData(plane_id, 0, "MyKey2", "MyValue2") - uid3 = pybullet.addUserData(plane_id, 0, "MyKey3", "MyValue3") - uid4 = pybullet.addUserData(plane_id, 0, "MyKey4", "MyValue4") + plane_id = self.client.loadURDF(PLANE_PATH) + uid1 = self.client.addUserData(plane_id, 0, "MyKey1", "MyValue1") + uid2 = self.client.addUserData(plane_id, 0, "MyKey2", "MyValue2") + uid3 = self.client.addUserData(plane_id, 0, "MyKey3", "MyValue3") + uid4 = self.client.addUserData(plane_id, 0, "MyKey4", "MyValue4") - pybullet.removeBody(plane_id) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid1)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid3)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid4)) + self.client.removeBody(plane_id) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid1)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid2)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid3)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid4)) - pybullet.disconnect() - pybullet.connect(pybullet.SHARED_MEMORY) + del self.client + self.client = bullet_client.BulletClient(pybullet.SHARED_MEMORY) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid1)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid2)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid3)) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid4)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid1)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid2)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid3)) + self.assertEqual(None, self.client.getUserData(plane_id, 0, uid4)) def testMultipleBodies(self): - pybullet.connect(pybullet.SHARED_MEMORY) - plane1 = pybullet.loadURDF(PLANE_PATH) - plane2 = pybullet.loadURDF(PLANE_PATH) + plane1 = self.client.loadURDF(PLANE_PATH) + plane2 = self.client.loadURDF(PLANE_PATH) - uid1 = pybullet.addUserData(plane1, 0, "MyKey1", "This is plane 1 - 1") - uid2 = pybullet.addUserData(plane1, 0, "MyKey2", "This is plane 1 - 2") + uid1 = self.client.addUserData(plane1, 0, "MyKey1", "This is plane 1 - 1") + uid2 = self.client.addUserData(plane1, 0, "MyKey2", "This is plane 1 - 2") - uid3 = pybullet.addUserData(plane2, 0, "MyKey1", "This is plane 2 - 1") - uid4 = pybullet.addUserData(plane2, 0, "MyKey2", "This is plane 2 - 2") - uid5 = pybullet.addUserData(plane2, 0, "MyKey3", "This is plane 2 - 3") + uid3 = self.client.addUserData(plane2, 0, "MyKey1", "This is plane 2 - 1") + uid4 = self.client.addUserData(plane2, 0, "MyKey2", "This is plane 2 - 2") + uid5 = self.client.addUserData(plane2, 0, "MyKey3", "This is plane 2 - 3") - self.assertEqual(b"This is plane 1 - 1", pybullet.getUserData(plane1, 0, pybullet.getUserDataId(plane1, 0, "MyKey1"))) - self.assertEqual(b"This is plane 1 - 2", pybullet.getUserData(plane1, 0, pybullet.getUserDataId(plane1, 0, "MyKey2"))) + self.assertEqual(b"This is plane 1 - 1", self.client.getUserData(plane1, 0, self.client.getUserDataId(plane1, 0, "MyKey1"))) + self.assertEqual(b"This is plane 1 - 2", self.client.getUserData(plane1, 0, self.client.getUserDataId(plane1, 0, "MyKey2"))) - self.assertEqual(b"This is plane 2 - 1", pybullet.getUserData(plane2, 0, pybullet.getUserDataId(plane2, 0, "MyKey1"))) - self.assertEqual(b"This is plane 2 - 2", pybullet.getUserData(plane2, 0, pybullet.getUserDataId(plane2, 0, "MyKey2"))) - self.assertEqual(b"This is plane 2 - 3", pybullet.getUserData(plane2, 0, pybullet.getUserDataId(plane2, 0, "MyKey3"))) + self.assertEqual(b"This is plane 2 - 1", self.client.getUserData(plane2, 0, self.client.getUserDataId(plane2, 0, "MyKey1"))) + self.assertEqual(b"This is plane 2 - 2", self.client.getUserData(plane2, 0, self.client.getUserDataId(plane2, 0, "MyKey2"))) + self.assertEqual(b"This is plane 2 - 3", self.client.getUserData(plane2, 0, self.client.getUserDataId(plane2, 0, "MyKey3"))) def testMultipleLinks(self): - pybullet.connect(pybullet.SHARED_MEMORY) - - body_id = pybullet.loadURDF(ROBOT_PATH) - num_links = pybullet.getNumJoints(body_id) + body_id = self.client.loadURDF(ROBOT_PATH) + num_links = self.client.getNumJoints(body_id) self.assertTrue(num_links > 1) for link_index in range(num_links): - uid1 = pybullet.addUserData(body_id, link_index, "MyKey1", "Value1 for link %s" % link_index) - uid2 = pybullet.addUserData(body_id, link_index, "MyKey2", "Value2 for link %s" % link_index) + uid1 = self.client.addUserData(body_id, link_index, "MyKey1", "Value1 for link %s" % link_index) + uid2 = self.client.addUserData(body_id, link_index, "MyKey2", "Value2 for link %s" % link_index) for link_index in range(num_links): - uid1 = pybullet.getUserDataId(body_id, link_index, "MyKey1") - uid2 = pybullet.getUserDataId(body_id, link_index, "MyKey2") - self.assertEqual(("Value1 for link %s" % link_index).encode(), pybullet.getUserData(body_id, link_index, uid1)) - self.assertEqual(("Value2 for link %s" % link_index).encode(), pybullet.getUserData(body_id, link_index, uid2)) + uid1 = self.client.getUserDataId(body_id, link_index, "MyKey1") + uid2 = self.client.getUserDataId(body_id, link_index, "MyKey2") + self.assertEqual(("Value1 for link %s" % link_index).encode(), self.client.getUserData(body_id, link_index, uid1)) + self.assertEqual(("Value2 for link %s" % link_index).encode(), self.client.getUserData(body_id, link_index, uid2)) def testMultipleClients(self): - client1 = self.client_id - client2 = pybullet.connect(pybullet.SHARED_MEMORY) + client1 = self.client + client2 = bullet_client.BulletClient(pybullet.SHARED_MEMORY) - plane_id = pybullet.loadURDF(PLANE_PATH, physicsClientId=client1) - pybullet.syncBodyInfo(physicsClientId=client2) + plane_id = client1.loadURDF(PLANE_PATH) + client2.syncBodyInfo() # Add user data on client 1, check on client 1 - uid = pybullet.addUserData(plane_id, 0, "MyKey", "MyValue", physicsClientId=client1) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid, physicsClientId=client2)) - pybullet.syncUserData(physicsClientId=client2) - self.assertEqual(b"MyValue", pybullet.getUserData(plane_id, 0, uid, physicsClientId=client2)) + uid = client1.addUserData(plane_id, 0, "MyKey", "MyValue") + self.assertEqual(None, client2.getUserData(plane_id, 0, uid)) + client2.syncUserData() + self.assertEqual(b"MyValue", client2.getUserData(plane_id, 0, uid)) # Overwrite the value on client 2, check on client 1 - pybullet.addUserData(plane_id, 0, "MyKey", "MyNewValue", physicsClientId=client2) - self.assertEqual(b"MyValue", pybullet.getUserData(plane_id, 0, uid, physicsClientId=client1)) - pybullet.syncUserData(physicsClientId=client1) - self.assertEqual(b"MyNewValue", pybullet.getUserData(plane_id, 0, uid, physicsClientId=client1)) + client2.addUserData(plane_id, 0, "MyKey", "MyNewValue") + self.assertEqual(b"MyValue", client1.getUserData(plane_id, 0, uid)) + client1.syncUserData() + self.assertEqual(b"MyNewValue", client1.getUserData(plane_id, 0, uid)) # Remove user data on client 1, check on client 2 - pybullet.removeUserData(plane_id, 0, uid, physicsClientId=client1) - self.assertEqual(b"MyNewValue", pybullet.getUserData(plane_id, 0, uid, physicsClientId=client2)) - pybullet.syncUserData(physicsClientId=client2) - self.assertEqual(None, pybullet.getUserData(plane_id, 0, uid, physicsClientId=client2)) + client1.removeUserData(plane_id, 0, uid) + self.assertEqual(b"MyNewValue", client2.getUserData(plane_id, 0, uid)) + client2.syncUserData() + self.assertEqual(None, client2.getUserData(plane_id, 0, uid)) - pybullet.disconnect(physicsClientId=client2) + del client2 if __name__ == "__main__": From aefd5a9d665aa5476dd855b525033e94a8450b56 Mon Sep 17 00:00:00 2001 From: Tigran Gasparian Date: Tue, 5 Jun 2018 09:28:38 +0200 Subject: [PATCH 3/3] Uses SHARED_MEMORY_SERVER instead of GUI_SERVER when starting a bullet server in the unit test. --- examples/pybullet/unittests/userDataTest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/pybullet/unittests/userDataTest.py b/examples/pybullet/unittests/userDataTest.py index 661298997..2b3db2cb4 100644 --- a/examples/pybullet/unittests/userDataTest.py +++ b/examples/pybullet/unittests/userDataTest.py @@ -11,7 +11,7 @@ class TestUserDataMethods(unittest.TestCase): @classmethod def setUpClass(cls): - TestUserDataMethods.server = bullet_client.BulletClient(connection_mode=pybullet.GUI_SERVER) + TestUserDataMethods.server = bullet_client.BulletClient(connection_mode=pybullet.SHARED_MEMORY_SERVER) @classmethod def tearDownClass(cls):