Bart/bullet3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix for issue in getAngleShortestPath()

Browse Source 
Testing squared norm for <0 does not make any sense. In Addition giving the range of the return values is a great help to understand the descriptions.
This commit is contained in:
Michael Korn
2016-03-04 22:01:29 +01:00
parent 03e85ad5a8
commit e80bafdf66
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/LinearMath/btQuaternion.h
View File

@@ -418,22 +418,21 @@ public:
return btAcos(dot(q) / s) * btScalar(2.0); return btAcos(dot(q) / s) * btScalar(2.0);
} }
/**@brief Return the angle of rotation represented by this quaternion */ /**@brief Return the angle [0, 2Pi] of rotation represented by this quaternion */
btScalar getAngle() const btScalar getAngle() const
{ {
btScalar s = btScalar(2.) * btAcos(m_floats[3]); btScalar s = btScalar(2.) * btAcos(m_floats[3]);
return s; return s;
} }
/**@brief Return the angle of rotation represented by this quaternion along the shortest path*/ /**@brief Return the angle [0, Pi] of rotation represented by this quaternion along the shortest path */
btScalar getAngleShortestPath() const btScalar getAngleShortestPath() const
{ {
btScalar s; btScalar s;
if (dot(*this) < 0) if (m_floats[3] >= 0)
s = btScalar(2.) * btAcos(m_floats[3]); s = btScalar(2.) * btAcos(m_floats[3]);
else else
s = btScalar(2.) * btAcos(-m_floats[3]); s = btScalar(2.) * btAcos(-m_floats[3]);
return s; return s;
} }