Craftadoc/clsi
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

improve error reporting

Browse Source
This commit is contained in:
Henry Oswald
2018-08-20 10:12:32 +01:00
parent 407c7c235b
commit 1990f20dc0
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/coffee/CompileManager.coffee
View File

@@ -290,7 +290,8 @@ module.exports = CompileManager =
return callback(error) if error? return callback(error) if error?
fs.readFile directory + "/" + file_name + ".wc", "utf-8", (err, stdout) -> fs.readFile directory + "/" + file_name + ".wc", "utf-8", (err, stdout) ->
if err? if err?
logger.err err:err, command:command, directory:directory, project_id:project_id, user_id:user_id, "error reading word count output" #call it node_err so sentry doesn't use random path error as unique id so it can't be ignored
logger.err node_err:err, command:command, directory:directory, project_id:project_id, user_id:user_id, "error reading word count output"
return callback(err) return callback(err)
results = CompileManager._parseWordcountFromOutput(stdout) results = CompileManager._parseWordcountFromOutput(stdout)
logger.log project_id:project_id, user_id:user_id, wordcount: results, "word count results" logger.log project_id:project_id, user_id:user_id, wordcount: results, "word count results"

2
app/coffee/DockerRunner.coffee
View File

@@ -214,7 +214,7 @@ module.exports = DockerRunner =
if error?.statusCode == 404 if error?.statusCode == 404
createAndStartContainer() createAndStartContainer()
else if error? else if error?
logger.err {container_name: name}, "unable to inspect container to start" logger.err {container_name: name, error:error}, "unable to inspect container to start"
return callback(error) return callback(error)
else else
startExistingContainer() startExistingContainer()