Craftadoc/clsi
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

set encoding when reading from streams

Browse Source 
using .toString() works most of the time but can lead to utf8 characters being
broken across chunk boundaries.

https://nodejs.org/api/stream.html#stream_readable_setencoding_encoding
This commit is contained in:
Brian Gough
2020-05-07 10:30:14 +01:00
parent 7254a025ae
commit 5b5fd2f5df
6 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/unit/js/CompileManagerTests.js
View File

@@ -294,6 +294,7 @@ describe('CompileManager', function() {
this.proc = new EventEmitter()
this.proc.stdout = new EventEmitter()
this.proc.stderr = new EventEmitter()
this.proc.stderr.setEncoding = sinon.stub().returns(this.proc.stderr)
this.child_process.spawn = sinon.stub().returns(this.proc)
this.CompileManager.clearProject(
this.project_id,
@@ -328,6 +329,7 @@ describe('CompileManager', function() {
this.proc = new EventEmitter()
this.proc.stdout = new EventEmitter()
this.proc.stderr = new EventEmitter()
this.proc.stderr.setEncoding = sinon.stub().returns(this.proc.stderr)
this.child_process.spawn = sinon.stub().returns(this.proc)
this.CompileManager.clearProject(
this.project_id,