Merge pull request #164 from overleaf/bg-fix-buffer-deprecations

fix deprecated usage of Buffer constructor

app/js/OutputFileOptimiser.js

@@ -45,8 +45,7 @@ module.exports = OutputFileOptimiser = {
 
   checkIfPDFIsOptimised(file, callback) {
     const SIZE = 16 * 1024 // check the header of the pdf
-    const result = new Buffer(SIZE)
-    result.fill(0) // prevent leakage of uninitialised buffer
+    const result = Buffer.alloc(SIZE) // fills with zeroes by default
     return fs.open(file, 'r', function(err, fd) {
       if (err != null) {
         return callback(err)

app/js/SafeReader.js

@@ -43,7 +43,7 @@ module.exports = SafeReader = {
           }
           return callback(null, ...Array.from(result))
         })
-      const buff = new Buffer(size, 0) // fill with zeros
+      const buff = Buffer.alloc(size) // fills with zeroes by default
       return fs.read(fd, buff, 0, buff.length, 0, function(
         err,
         bytesRead,