Craftadoc/clsi
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #103 from sharelatex/ho-mute-sentry-errors

Browse Source 
have failed compiles warn rather than be an error
This commit is contained in:
Henry Oswald
2018-11-28 22:35:51 +09:00
committed by GitHub
parent f1ab938bab 49f3b7d54f
commit 75e77a3991
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/coffee/CompileController.coffee
View File

@@ -33,7 +33,7 @@ module.exports = CompileController =
else else
status = "error" status = "error"
code = 500 code = 500
logger.error err: error, project_id: request.project_id, "error running compile" logger.warn err: error, project_id: request.project_id, "error running compile"
else else
status = "failure" status = "failure"
@@ -42,7 +42,7 @@ module.exports = CompileController =
status = "success" status = "success"
if status == "failure" if status == "failure"
logger.err project_id: request.project_id, outputFiles:outputFiles, "project failed to compile successfully, no output.pdf generated" logger.warn project_id: request.project_id, outputFiles:outputFiles, "project failed to compile successfully, no output.pdf generated"
# log an error if any core files are found # log an error if any core files are found
for file in outputFiles for file in outputFiles

2
test/unit/coffee/CompileControllerTests.coffee
View File

@@ -14,7 +14,7 @@ describe "CompileController", ->
clsi: clsi:
url: "http://clsi.example.com" url: "http://clsi.example.com"
"./ProjectPersistenceManager": @ProjectPersistenceManager = {} "./ProjectPersistenceManager": @ProjectPersistenceManager = {}
"logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), err:sinon.stub() } "logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), err:sinon.stub(), warn: sinon.stub()}
@Settings.externalUrl = "http://www.example.com" @Settings.externalUrl = "http://www.example.com"
@req = {} @req = {}
@res = {} @res = {}