From 638d2f30d3f7f3a78b1bbf586fdb8398428e4c04 Mon Sep 17 00:00:00 2001
From: Jakob Ackermann <das7pad@outlook.com>
Date: Thu, 26 Mar 2020 11:18:50 +0100
Subject: [PATCH] [misc] add a metric for failing downloads

---
 app/js/ResourceWriter.js            | 1 +
 test/unit/js/ResourceWriterTests.js | 1 +
 2 files changed, 2 insertions(+)

diff --git a/app/js/ResourceWriter.js b/app/js/ResourceWriter.js
index 5a234e0..ed3a1e8 100644
--- a/app/js/ResourceWriter.js
+++ b/app/js/ResourceWriter.js
@@ -324,6 +324,7 @@ module.exports = ResourceWriter = {
                   },
                   'error downloading file for resources'
                 )
+                Metrics.inc('download-failed')
               }
               return callback()
             }
diff --git a/test/unit/js/ResourceWriterTests.js b/test/unit/js/ResourceWriterTests.js
index 68aa456..a632c1b 100644
--- a/test/unit/js/ResourceWriterTests.js
+++ b/test/unit/js/ResourceWriterTests.js
@@ -36,6 +36,7 @@ describe('ResourceWriter', function() {
         './OutputFileFinder': (this.OutputFileFinder = {}),
         'logger-sharelatex': { log: sinon.stub(), err: sinon.stub() },
         './Metrics': (this.Metrics = {
+          inc: sinon.stub(),
           Timer: (Timer = (function() {
             Timer = class Timer {
               static initClass() {