[misc] apply review feedback

- move setting into clsi.docker namespace
- rename the variable for images to allowedImages / ALLOWED_IMAGES
- add an additional check for the image name into the DockerRunner

Co-Authored-By: Brian Gough <brian.gough@overleaf.com>
This commit is contained in:
Jakob Ackermann
2020-06-30 12:00:18 +01:00
parent 6edb458910
commit ee0e8066d3
8 changed files with 96 additions and 19 deletions

View File

@@ -91,6 +91,13 @@ module.exports = DockerRunner = {
image = `${Settings.texliveImageNameOveride}/${img[2]}`
}
if (
Settings.clsi.docker.allowedImages &&
!Settings.clsi.docker.allowedImages.includes(image)
) {
return callback(new Error('image not allowed'))
}
const options = DockerRunner._getContainerOptions(
command,
image,