[misc] bump the dev-env to 3.3.2

app/js/UrlCache.js

@@ -25,7 +25,7 @@ const async = require('async')
 module.exports = UrlCache = {
   downloadUrlToFile(project_id, url, destPath, lastModified, callback) {
     if (callback == null) {
-      callback = function(error) {}
+      callback = function (error) {}
     }
     return UrlCache._ensureUrlIsInCache(
       project_id,
@@ -35,7 +35,7 @@ module.exports = UrlCache = {
         if (error != null) {
           return callback(error)
         }
-        return UrlCache._copyFile(pathToCachedUrl, destPath, function(error) {
+        return UrlCache._copyFile(pathToCachedUrl, destPath, function (error) {
           if (error != null) {
             return UrlCache._clearUrlDetails(project_id, url, () =>
               callback(error)
@@ -50,9 +50,9 @@ module.exports = UrlCache = {
 
   clearProject(project_id, callback) {
     if (callback == null) {
-      callback = function(error) {}
+      callback = function (error) {}
     }
-    return UrlCache._findAllUrlsInProject(project_id, function(error, urls) {
+    return UrlCache._findAllUrlsInProject(project_id, function (error, urls) {
       logger.log(
         { project_id, url_count: urls.length },
         'clearing project URLs'
@@ -60,9 +60,9 @@ module.exports = UrlCache = {
       if (error != null) {
         return callback(error)
       }
-      const jobs = Array.from(urls || []).map(url =>
-        (url => callback =>
-          UrlCache._clearUrlFromCache(project_id, url, function(error) {
+      const jobs = Array.from(urls || []).map((url) =>
+        ((url) => (callback) =>
+          UrlCache._clearUrlFromCache(project_id, url, function (error) {
             if (error != null) {
               logger.error(
                 { err: error, project_id, url },
@@ -78,7 +78,7 @@ module.exports = UrlCache = {
 
   _ensureUrlIsInCache(project_id, url, lastModified, callback) {
     if (callback == null) {
-      callback = function(error, pathOnDisk) {}
+      callback = function (error, pathOnDisk) {}
     }
     if (lastModified != null) {
       // MYSQL only stores dates to an accuracy of a second but the incoming lastModified might have milliseconds.
@@ -98,7 +98,7 @@ module.exports = UrlCache = {
           return UrlFetcher.pipeUrlToFileWithRetry(
             url,
             UrlCache._cacheFilePathForUrl(project_id, url),
-            error => {
+            (error) => {
               if (error != null) {
                 return callback(error)
               }
@@ -106,7 +106,7 @@ module.exports = UrlCache = {
                 project_id,
                 url,
                 lastModified,
-                error => {
+                (error) => {
                   if (error != null) {
                     return callback(error)
                   }
@@ -128,12 +128,12 @@ module.exports = UrlCache = {
 
   _doesUrlNeedDownloading(project_id, url, lastModified, callback) {
     if (callback == null) {
-      callback = function(error, needsDownloading) {}
+      callback = function (error, needsDownloading) {}
     }
     if (lastModified == null) {
       return callback(null, true)
     }
-    return UrlCache._findUrlDetails(project_id, url, function(
+    return UrlCache._findUrlDetails(project_id, url, function (
       error,
       urlDetails
     ) {
@@ -153,14 +153,7 @@ module.exports = UrlCache = {
   },
 
   _cacheFileNameForUrl(project_id, url) {
-    return (
-      project_id +
-      ':' +
-      crypto
-        .createHash('md5')
-        .update(url)
-        .digest('hex')
-    )
+    return project_id + ':' + crypto.createHash('md5').update(url).digest('hex')
   },
 
   _cacheFilePathForUrl(project_id, url) {
@@ -172,14 +165,14 @@ module.exports = UrlCache = {
 
   _copyFile(from, to, _callback) {
     if (_callback == null) {
-      _callback = function(error) {}
+      _callback = function (error) {}
     }
-    const callbackOnce = function(error) {
+    const callbackOnce = function (error) {
       if (error != null) {
         logger.error({ err: error, from, to }, 'error copying file from cache')
       }
       _callback(error)
-      return (_callback = function() {})
+      return (_callback = function () {})
     }
     const writeStream = fs.createWriteStream(to)
     const readStream = fs.createReadStream(from)
@@ -191,13 +184,15 @@ module.exports = UrlCache = {
 
   _clearUrlFromCache(project_id, url, callback) {
     if (callback == null) {
-      callback = function(error) {}
+      callback = function (error) {}
     }
-    return UrlCache._clearUrlDetails(project_id, url, function(error) {
+    return UrlCache._clearUrlDetails(project_id, url, function (error) {
       if (error != null) {
         return callback(error)
       }
-      return UrlCache._deleteUrlCacheFromDisk(project_id, url, function(error) {
+      return UrlCache._deleteUrlCacheFromDisk(project_id, url, function (
+        error
+      ) {
         if (error != null) {
           return callback(error)
         }
@@ -208,9 +203,9 @@ module.exports = UrlCache = {
 
   _deleteUrlCacheFromDisk(project_id, url, callback) {
     if (callback == null) {
-      callback = function(error) {}
+      callback = function (error) {}
     }
-    return fs.unlink(UrlCache._cacheFilePathForUrl(project_id, url), function(
+    return fs.unlink(UrlCache._cacheFilePathForUrl(project_id, url), function (
       error
     ) {
       if (error != null && error.code !== 'ENOENT') {
@@ -224,20 +219,20 @@ module.exports = UrlCache = {
 
   _findUrlDetails(project_id, url, callback) {
     if (callback == null) {
-      callback = function(error, urlDetails) {}
+      callback = function (error, urlDetails) {}
     }
-    const job = cb =>
+    const job = (cb) =>
       db.UrlCache.findOne({ where: { url, project_id } })
-        .then(urlDetails => cb(null, urlDetails))
+        .then((urlDetails) => cb(null, urlDetails))
         .error(cb)
     return dbQueue.queue.push(job, callback)
   },
 
   _updateOrCreateUrlDetails(project_id, url, lastModified, callback) {
     if (callback == null) {
-      callback = function(error) {}
+      callback = function (error) {}
     }
-    const job = cb =>
+    const job = (cb) =>
       db.UrlCache.findOrCreate({ where: { url, project_id } })
         .spread((urlDetails, created) =>
           urlDetails
@@ -251,9 +246,9 @@ module.exports = UrlCache = {
 
   _clearUrlDetails(project_id, url, callback) {
     if (callback == null) {
-      callback = function(error) {}
+      callback = function (error) {}
     }
-    const job = cb =>
+    const job = (cb) =>
       db.UrlCache.destroy({ where: { url, project_id } })
         .then(() => cb(null))
         .error(cb)
@@ -262,14 +257,14 @@ module.exports = UrlCache = {
 
   _findAllUrlsInProject(project_id, callback) {
     if (callback == null) {
-      callback = function(error, urls) {}
+      callback = function (error, urls) {}
     }
-    const job = cb =>
+    const job = (cb) =>
       db.UrlCache.findAll({ where: { project_id } })
-        .then(urlEntries =>
+        .then((urlEntries) =>
           cb(
             null,
-            urlEntries.map(entry => entry.url)
+            urlEntries.map((entry) => entry.url)
           )
         )
         .error(cb)