Craftadoc/clsi
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[misc] bump the dev-env to 3.3.2

Browse Source
This commit is contained in:
Jakob Ackermann
2020-08-10 17:01:11 +01:00
parent 1ee48d0274
commit f4561c2fe2
66 changed files with 1371 additions and 1458 deletions
Download Patch File Download Diff File Expand all files Collapse all files

180
test/unit/js/RequestParserTests.js
View File

@@ -19,8 +19,8 @@ const modulePath = require('path').join(
)
const tk = require('timekeeper')
describe('RequestParser', function() {
beforeEach(function() {
describe('RequestParser', function () {
beforeEach(function () {
tk.freeze()
this.callback = sinon.stub()
this.validResource = {
@@ -46,41 +46,41 @@ describe('RequestParser', function() {
}))
})
afterEach(function() {
afterEach(function () {
return tk.reset()
})
describe('without a top level object', function() {
beforeEach(function() {
describe('without a top level object', function () {
beforeEach(function () {
return this.RequestParser.parse([], this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('top level object should have a compile attribute')
.should.equal(true)
})
})
describe('without a compile attribute', function() {
beforeEach(function() {
describe('without a compile attribute', function () {
beforeEach(function () {
return this.RequestParser.parse({}, this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('top level object should have a compile attribute')
.should.equal(true)
})
})
describe('without a valid compiler', function() {
beforeEach(function() {
describe('without a valid compiler', function () {
beforeEach(function () {
this.validRequest.compile.options.compiler = 'not-a-compiler'
return this.RequestParser.parse(this.validRequest, this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith(
'compiler attribute should be one of: pdflatex, latex, xelatex, lualatex'
@@ -89,33 +89,33 @@ describe('RequestParser', function() {
})
})
describe('without a compiler specified', function() {
beforeEach(function() {
describe('without a compiler specified', function () {
beforeEach(function () {
delete this.validRequest.compile.options.compiler
return this.RequestParser.parse(this.validRequest, (error, data) => {
this.data = data
})
})
return it('should set the compiler to pdflatex by default', function() {
return it('should set the compiler to pdflatex by default', function () {
return this.data.compiler.should.equal('pdflatex')
})
})
describe('with imageName set', function() {
beforeEach(function() {
describe('with imageName set', function () {
beforeEach(function () {
return this.RequestParser.parse(this.validRequest, (error, data) => {
this.data = data
})
})
return it('should set the imageName', function() {
return it('should set the imageName', function () {
return this.data.imageName.should.equal('basicImageName/here:2017-1')
})
})
describe('when image restrictions are present', function() {
beforeEach(function() {
describe('when image restrictions are present', function () {
beforeEach(function () {
this.settings.clsi = { docker: {} }
this.settings.clsi.docker.allowedImages = [
'repo/name:tag1',
@@ -123,8 +123,8 @@ describe('RequestParser', function() {
]
})
describe('with imageName set to something invalid', function() {
beforeEach(function() {
describe('with imageName set to something invalid', function () {
beforeEach(function () {
const request = this.validRequest
request.compile.options.imageName = 'something/different:latest'
this.RequestParser.parse(request, (error, data) => {
@@ -133,15 +133,15 @@ describe('RequestParser', function() {
})
})
it('should throw an error for imageName', function() {
it('should throw an error for imageName', function () {
expect(String(this.error)).to.include(
'imageName attribute should be one of'
)
})
})
describe('with imageName set to something valid', function() {
beforeEach(function() {
describe('with imageName set to something valid', function () {
beforeEach(function () {
const request = this.validRequest
request.compile.options.imageName = 'repo/name:tag1'
this.RequestParser.parse(request, (error, data) => {
@@ -150,54 +150,54 @@ describe('RequestParser', function() {
})
})
it('should set the imageName', function() {
it('should set the imageName', function () {
this.data.imageName.should.equal('repo/name:tag1')
})
})
})
describe('with flags set', function() {
beforeEach(function() {
describe('with flags set', function () {
beforeEach(function () {
this.validRequest.compile.options.flags = ['-file-line-error']
return this.RequestParser.parse(this.validRequest, (error, data) => {
this.data = data
})
})
return it('should set the flags attribute', function() {
return it('should set the flags attribute', function () {
return expect(this.data.flags).to.deep.equal(['-file-line-error'])
})
})
describe('with flags not specified', function() {
beforeEach(function() {
describe('with flags not specified', function () {
beforeEach(function () {
return this.RequestParser.parse(this.validRequest, (error, data) => {
this.data = data
})
})
return it('it should have an empty flags list', function() {
return it('it should have an empty flags list', function () {
return expect(this.data.flags).to.deep.equal([])
})
})
describe('without a timeout specified', function() {
beforeEach(function() {
describe('without a timeout specified', function () {
beforeEach(function () {
delete this.validRequest.compile.options.timeout
return this.RequestParser.parse(this.validRequest, (error, data) => {
this.data = data
})
})
return it('should set the timeout to MAX_TIMEOUT', function() {
return it('should set the timeout to MAX_TIMEOUT', function () {
return this.data.timeout.should.equal(
this.RequestParser.MAX_TIMEOUT * 1000
)
})
})
describe('with a timeout larger than the maximum', function() {
beforeEach(function() {
describe('with a timeout larger than the maximum', function () {
beforeEach(function () {
this.validRequest.compile.options.timeout =
this.RequestParser.MAX_TIMEOUT + 1
return this.RequestParser.parse(this.validRequest, (error, data) => {
@@ -205,62 +205,62 @@ describe('RequestParser', function() {
})
})
return it('should set the timeout to MAX_TIMEOUT', function() {
return it('should set the timeout to MAX_TIMEOUT', function () {
return this.data.timeout.should.equal(
this.RequestParser.MAX_TIMEOUT * 1000
)
})
})
describe('with a timeout', function() {
beforeEach(function() {
describe('with a timeout', function () {
beforeEach(function () {
return this.RequestParser.parse(this.validRequest, (error, data) => {
this.data = data
})
})
return it('should set the timeout (in milliseconds)', function() {
return it('should set the timeout (in milliseconds)', function () {
return this.data.timeout.should.equal(
this.validRequest.compile.options.timeout * 1000
)
})
})
describe('with a resource without a path', function() {
beforeEach(function() {
describe('with a resource without a path', function () {
beforeEach(function () {
delete this.validResource.path
this.validRequest.compile.resources.push(this.validResource)
return this.RequestParser.parse(this.validRequest, this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('all resources should have a path attribute')
.should.equal(true)
})
})
describe('with a resource with a path', function() {
beforeEach(function() {
describe('with a resource with a path', function () {
beforeEach(function () {
this.validResource.path = this.path = 'test.tex'
this.validRequest.compile.resources.push(this.validResource)
this.RequestParser.parse(this.validRequest, this.callback)
return (this.data = this.callback.args[0][1])
})
return it('should return the path in the parsed response', function() {
return it('should return the path in the parsed response', function () {
return this.data.resources[0].path.should.equal(this.path)
})
})
describe('with a resource with a malformed modified date', function() {
beforeEach(function() {
describe('with a resource with a malformed modified date', function () {
beforeEach(function () {
this.validResource.modified = 'not-a-date'
this.validRequest.compile.resources.push(this.validResource)
return this.RequestParser.parse(this.validRequest, this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith(
'resource modified date could not be understood: ' +
@@ -270,8 +270,8 @@ describe('RequestParser', function() {
})
})
describe('with a resource with a valid date', function() {
beforeEach(function() {
describe('with a resource with a valid date', function () {
beforeEach(function () {
this.date = '12:00 01/02/03'
this.validResource.modified = this.date
this.validRequest.compile.resources.push(this.validResource)
@@ -279,7 +279,7 @@ describe('RequestParser', function() {
return (this.data = this.callback.args[0][1])
})
return it('should return the date as a Javascript Date object', function() {
return it('should return the date as a Javascript Date object', function () {
;(this.data.resources[0].modified instanceof Date).should.equal(true)
return this.data.resources[0].modified
.getTime()
@@ -287,15 +287,15 @@ describe('RequestParser', function() {
})
})
describe('with a resource without either a content or URL attribute', function() {
beforeEach(function() {
describe('with a resource without either a content or URL attribute', function () {
beforeEach(function () {
delete this.validResource.url
delete this.validResource.content
this.validRequest.compile.resources.push(this.validResource)
return this.RequestParser.parse(this.validRequest, this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith(
'all resources should have either a url or content attribute'
@@ -304,99 +304,99 @@ describe('RequestParser', function() {
})
})
describe('with a resource where the content is not a string', function() {
beforeEach(function() {
describe('with a resource where the content is not a string', function () {
beforeEach(function () {
this.validResource.content = []
this.validRequest.compile.resources.push(this.validResource)
return this.RequestParser.parse(this.validRequest, this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('content attribute should be a string')
.should.equal(true)
})
})
describe('with a resource where the url is not a string', function() {
beforeEach(function() {
describe('with a resource where the url is not a string', function () {
beforeEach(function () {
this.validResource.url = []
this.validRequest.compile.resources.push(this.validResource)
return this.RequestParser.parse(this.validRequest, this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('url attribute should be a string')
.should.equal(true)
})
})
describe('with a resource with a url', function() {
beforeEach(function() {
describe('with a resource with a url', function () {
beforeEach(function () {
this.validResource.url = this.url = 'www.example.com'
this.validRequest.compile.resources.push(this.validResource)
this.RequestParser.parse(this.validRequest, this.callback)
return (this.data = this.callback.args[0][1])
})
return it('should return the url in the parsed response', function() {
return it('should return the url in the parsed response', function () {
return this.data.resources[0].url.should.equal(this.url)
})
})
describe('with a resource with a content attribute', function() {
beforeEach(function() {
describe('with a resource with a content attribute', function () {
beforeEach(function () {
this.validResource.content = this.content = 'Hello world'
this.validRequest.compile.resources.push(this.validResource)
this.RequestParser.parse(this.validRequest, this.callback)
return (this.data = this.callback.args[0][1])
})
return it('should return the content in the parsed response', function() {
return it('should return the content in the parsed response', function () {
return this.data.resources[0].content.should.equal(this.content)
})
})
describe('without a root resource path', function() {
beforeEach(function() {
describe('without a root resource path', function () {
beforeEach(function () {
delete this.validRequest.compile.rootResourcePath
this.RequestParser.parse(this.validRequest, this.callback)
return (this.data = this.callback.args[0][1])
})
return it("should set the root resource path to 'main.tex' by default", function() {
return it("should set the root resource path to 'main.tex' by default", function () {
return this.data.rootResourcePath.should.equal('main.tex')
})
})
describe('with a root resource path', function() {
beforeEach(function() {
describe('with a root resource path', function () {
beforeEach(function () {
this.validRequest.compile.rootResourcePath = this.path = 'test.tex'
this.RequestParser.parse(this.validRequest, this.callback)
return (this.data = this.callback.args[0][1])
})
return it('should return the root resource path in the parsed response', function() {
return it('should return the root resource path in the parsed response', function () {
return this.data.rootResourcePath.should.equal(this.path)
})
})
describe('with a root resource path that is not a string', function() {
beforeEach(function() {
describe('with a root resource path that is not a string', function () {
beforeEach(function () {
this.validRequest.compile.rootResourcePath = []
return this.RequestParser.parse(this.validRequest, this.callback)
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('rootResourcePath attribute should be a string')
.should.equal(true)
})
})
describe('with a root resource path that needs escaping', function() {
beforeEach(function() {
describe('with a root resource path that needs escaping', function () {
beforeEach(function () {
this.badPath = '`rm -rf foo`.tex'
this.goodPath = 'rm -rf foo.tex'
this.validRequest.compile.rootResourcePath = this.badPath
@@ -409,51 +409,51 @@ describe('RequestParser', function() {
return (this.data = this.callback.args[0][1])
})
it('should return the escaped resource', function() {
it('should return the escaped resource', function () {
return this.data.rootResourcePath.should.equal(this.goodPath)
})
return it('should also escape the resource path', function() {
return it('should also escape the resource path', function () {
return this.data.resources[0].path.should.equal(this.goodPath)
})
})
describe('with a root resource path that has a relative path', function() {
beforeEach(function() {
describe('with a root resource path that has a relative path', function () {
beforeEach(function () {
this.validRequest.compile.rootResourcePath = 'foo/../../bar.tex'
this.RequestParser.parse(this.validRequest, this.callback)
return (this.data = this.callback.args[0][1])
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('relative path in root resource')
.should.equal(true)
})
})
describe('with a root resource path that has unescaped + relative path', function() {
beforeEach(function() {
describe('with a root resource path that has unescaped + relative path', function () {
beforeEach(function () {
this.validRequest.compile.rootResourcePath = 'foo/#../bar.tex'
this.RequestParser.parse(this.validRequest, this.callback)
return (this.data = this.callback.args[0][1])
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('relative path in root resource')
.should.equal(true)
})
})
return describe('with an unknown syncType', function() {
beforeEach(function() {
return describe('with an unknown syncType', function () {
beforeEach(function () {
this.validRequest.compile.options.syncType = 'unexpected'
this.RequestParser.parse(this.validRequest, this.callback)
return (this.data = this.callback.args[0][1])
})
return it('should return an error', function() {
return it('should return an error', function () {
return this.callback
.calledWith('syncType attribute should be one of: full, incremental')
.should.equal(true)