Eric Mc Sween
9ab5738ae3
Decaf cleanup: remove unnecessary returns
2020-09-02 16:58:41 -04:00
Eric Mc Sween
ca61354cfe
Decaf cleanup: remove unnecessary Array.from()
2020-09-02 16:45:49 -04:00
Jakob Ackermann
f4561c2fe2
[misc] bump the dev-env to 3.3.2
2020-08-10 17:01:11 +01:00
Jakob Ackermann
0cecf26569
[misc] move the image check prior to the base image override
2020-07-01 10:01:25 +01:00
Jakob Ackermann
ee0e8066d3
[misc] apply review feedback
...
- move setting into clsi.docker namespace
- rename the variable for images to allowedImages / ALLOWED_IMAGES
- add an additional check for the image name into the DockerRunner
Co-Authored-By: Brian Gough <brian.gough@overleaf.com >
2020-06-30 12:01:21 +01:00
Brian Gough
6b69e26de3
Merge branch 'master' into bg-add-compile-groups
2020-06-17 11:58:26 +01:00
Brian Gough
74a11c7be3
fix format
2020-06-16 08:45:53 +01:00
Brian Gough
1f3217f598
Merge branch 'master' into bg-use-lodash
2020-06-16 08:35:17 +01:00
Brian Gough
b33734bab6
add initial compileGroup support
2020-06-15 15:28:53 +01:00
Brian Gough
9b92793b89
migrate from underscore to lodash
2020-06-15 09:52:21 +01:00
Tim Alby
7ceadc8599
partially revert "[DockerRunner] fix metric incrementing and error logging"
...
This reverts commits:
- 2b2fcca39c
- 9e82ab0890
- e3da458b37
2020-06-11 12:51:26 +02:00
Brian Gough
17c14b1192
fix formatting with make format_fix
2020-06-02 09:18:38 +01:00
Brian Gough
8c60406bb5
Merge pull request #170 from overleaf/jpa-import-141
...
[DockerRunner] destroyOldContainers: fix a race confition
2020-06-02 09:04:59 +01:00
Jakob Ackermann
f8cb5e36af
[DockerRunner] destroyOldContainers: normalize the container name
...
The docker api returns each name with a `/` prefix.
In order to not interfere with pending compiles, the deletion process
has to acquire an internal lock on the container. The LockManager uses
the plain container name without the slash: `project-xxx`.
Signed-off-by: Jakob Ackermann <das7pad@outlook.com >
2020-05-29 11:28:26 +01:00
Henry Oswald
fec359afac
Merge pull request #162 from overleaf/ta-jpa-epipe-retry
...
[DockerRunner] retry container inspect on EPIPE
2020-05-19 11:15:25 +01:00
Henry Oswald
4bd567b78d
Merge branch 'master' into bg-support-other-runtimes
...
port coffee changes to js
2020-04-23 13:59:05 +01:00
Jakob Ackermann
2b2fcca39c
[DockerRunner] fix metric incrementing and error logging
...
- do not log on first EPIPE
- inc 'container-inspect-epipe-error' on permanent error only
Co-Authored-By: Tim Alby <timothee.alby@gmail.com >
2020-04-10 14:44:57 +02:00
Tim Alby
9e82ab0890
add metrics for EPIPE errors
...
Co-Authored-By: Jakob Ackermann <jakob.ackermann@overleaf.com >
2020-04-10 12:28:48 +02:00
Tim Alby
e3da458b37
retry once on EPIPE errors
...
Co-Authored-By: Jakob Ackermann <jakob.ackermann@overleaf.com >
2020-04-10 12:28:11 +02:00
Jakob Ackermann
4a26ec975f
[misc] keep up with the error signature of dockerode/docker-modem
...
https://github.com/apocas/docker-modem/blob/v2.1.1/lib/modem.js#L296
2020-03-27 10:39:45 +01:00
mserranom
ee12573b06
added container monitor cleanup to fix hanging tests
2020-02-20 17:24:28 +01:00
mserranom
cffbd4e9ef
prettier: convert app/js decaffeinated files to Prettier format
2020-02-19 12:14:37 +01:00
mserranom
4576ef54fb
decaffeinate: rename app/coffee dir to app/js
2020-02-19 12:14:34 +01:00