Craftadoc/clsi
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

clean up log file deletion and add unit test

Browse Source
This commit is contained in:
Brian Gough
2020-05-20 14:12:08 +01:00
parent e3c278e708
commit 1bcb370ca1
2 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/js/ResourceWriter.js
View File

@@ -201,10 +201,6 @@ module.exports = ResourceWriter = {
// knitr cache
should_delete = false
}
if (path.match(/^output.(stdout|stderr)$/)) {
// latexmk output
should_delete = true
}
if (path.match(/^output-.*/)) {
// Tikz cached figures (default case)
should_delete = false
@@ -235,7 +231,9 @@ module.exports = ResourceWriter = {
path === 'output.pdf' ||
path === 'output.dvi' ||
path === 'output.log' ||
path === 'output.xdv'
path === 'output.xdv' ||
path === 'output.stdout' ||
path === 'output.stderr'
) {
should_delete = true
}

20
test/unit/js/ResourceWriterTests.js
View File

@@ -230,6 +230,12 @@ describe('ResourceWriter', function() {
{
path: '_markdown_main/30893013dec5d869a415610079774c2f.md.tex',
type: 'tex'
},
{
path: 'output.stdout'
},
{
path: 'output.stderr'
}
]
this.resources = 'mock-resources'
@@ -256,7 +262,19 @@ describe('ResourceWriter', function() {
.should.equal(true)
})
it('should delete the extra files', function() {
it('should delete the stdout log file', function () {
return this.ResourceWriter._deleteFileIfNotDirectory
.calledWith(path.join(this.basePath, 'output.stdout'))
.should.equal(true)
})
it('should delete the stderr log file', function () {
return this.ResourceWriter._deleteFileIfNotDirectory
.calledWith(path.join(this.basePath, 'output.stderr'))
.should.equal(true)
})
it('should delete the extra files', function () {
return this.ResourceWriter._deleteFileIfNotDirectory
.calledWith(path.join(this.basePath, 'extra/file.tex'))
.should.equal(true)